Data3Sixty DQ+ Pre-Packaged Rule Library Rules

Comments

7 comments

  • Avatar
    Rob McCurley

    The rule ZC_Min_5_Digits_US seems to have an error in it. The regex pattern for this rule, "^ [0-9]{5,}$|^$", has an extra space between the initial carat (^) and the square brace. If this space is removed ("^[0-9]{5,}$|^$") the rule works as described.

    0
    Comment actions Permalink
  • Avatar
    Rob McCurley

    Also note that the rule appears in two places under the same name - both have the same problem.

    0
    Comment actions Permalink
  • Avatar
    Jeffery Brown

    Hi Rob,

       Thank you so much for the update.  We are currently in the process of updating the pre-packaged DQ+ rules and will be making changes to the rules you mentioned above.  We will be adding some additional Field checks and consolidating some of the redundant rules found in the other checks. That should make it easier to be able to include all of the checks for a single field rather, than picking an choosing.  We will basically version the next group of rules, so that both sets will be available. 

     

    Jeff

    0
    Comment actions Permalink
  • Avatar
    Rob McCurley

    I agree some consolidation and refactoring of the rules to remove redundancy would be an improvement. Feel free to contact me if you need a pre-release reviewer!

    0
    Comment actions Permalink
  • Avatar
    Jim O'Leary

    Hi Jeff-

     

    Unless I'm mistaken, it seems that ZC_Min_5_Digits_US still has a space after ^ in the latest on-prem version of the DQ rules.

     

    Maybe it missed the cutoff for corrections.

     

    Thanks,

     

    jim

    1
    Comment actions Permalink
  • Avatar
    Jim O'Leary

    Hi Jeff-

    Some comments about a few Zip_Code_Rules.

    Here is the regular expression for the rule ZC_5_9_10_Digits_US:

    ([0-9]{5})|([0-9]{9})|([0-9]{10})|^$

    1. This seems to allow for ten numeric digits which, to my knowledge, is invalid as opposed to nnnnn-nnn (Zip+4), which doesn't seem to be represented here.

    2. Doesn't that last ^$ mean it allows for the empty string? Is that intended?


    Most other zip code rules are bracketed by ^ and $; for example, ZC_Max_5_Digits_US:

    ^[0-9]{0,5}$

    Should ZC_5_9_10_Digits_US also be similarly bracketed?


    And, speaking of ZC_Max_5_Digits_US, which allows for zero-to-five numeric digits, can't we have a ZC_Exactly_5_Digits_US?


    Thanks,


    jim

     

    1
    Comment actions Permalink
  • Avatar
    Jeffery Brown

    Thanks Jim.  We appreciate your comments.  We will be reviewing and incorporating fixes to your comments above around zip code.  We plan to release a new set of DQ Library Rules in the next week or so, which will include several more field (data element) checks along with updates based on everyone's feedback in the community.

    0
    Comment actions Permalink

Please sign in to leave a comment.



Powered by Zendesk